Skip to content

Updates on the PingSource #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2020
Merged

Updates on the PingSource #2274

merged 2 commits into from
Mar 10, 2020

Conversation

@matzew
Copy link
Member

@matzew matzew commented Mar 5, 2020

Proposed Changes

  • update doc to use v1alpha2 of PingSource

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 5, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2020
@matzew
Copy link
Member Author

matzew commented Mar 5, 2020

/assign @lionelvillard
/assign @n3wscott

@matzew
Copy link
Member Author

matzew commented Mar 5, 2020

/hold

let's get #2126 in first!

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2020
matzew added 2 commits March 9, 2020 12:20
@matzew
Updates on the PingSource
5c682a3 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Updates on the PingSource
792e040 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the using_latest_ping_source_alpha2 branch from bf643f6 to 792e040 Compare March 9, 2020 11:20
@matzew matzew mentioned this pull request Mar 9, 2020
Closed
@matzew
Copy link
Member Author

matzew commented Mar 9, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
@lionelvillard
Copy link
Contributor

lionelvillard commented Mar 9, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@matzew
Copy link
Member Author

matzew commented Mar 9, 2020

/cc @n3wscott
/cc @vaikas

@n3wscott
Copy link
Contributor

n3wscott commented Mar 10, 2020

/lgtm

@vaikas
Copy link
Contributor

vaikas commented Mar 10, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d2b6b0e into knative:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@n3wscott n3wscott Awaiting requested review from n3wscott

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@lionelvillard lionelvillard

@vaikas vaikas

@n3wscott n3wscott

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matzew @lionelvillard @n3wscott @vaikas @knative-prow-robot @googlebot