Skip to content

Conversation

@houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Mar 12, 2020

Cherry-pick of 38dd475

Proposed Changes

  • Add instruction in how to install Knative with Knative operators

  • Fix the operators's doc based on comments

  • Modify the docs of Operators to outline better

  • Fixes the typos

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 12, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2020
* Add instruction in how to install Knative with Knative operators

* Fix the operators's doc based on comments

* Modify the docs of Operators to outline better

* Fixes the typos
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge my suggestion, I'll send a followup PR to clean up the docs and then merge that along with a few other needed docs PRs.

/lgtm
/approve

Run the following command to install Knative Serving Operator:

```
kubectl apply -f https://github.com/knative/serving-operator/releases/download/v0.13.0/serving-operator.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be {{< version >}} to auto-substitute in the release version, IIRC.

Even better, there is an {{< artifact >}} tag, like so:

Suggested change
kubectl apply -f https://github.com/knative/serving-operator/releases/download/v0.13.0/serving-operator.yaml
kubectl apply --filename {{< artifact repo="serving-operator" file="serving-operator.yaml" >}}

I'll send this as a PR on the upstream docs, so this is mostly FYI.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f9b9c33 into knative:release-0.13 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants