Skip to content

Conversation

@mpetason
Copy link
Contributor

Fixes readability and matches serving docs where you will clone the docs first so that you are aware of where the files are.

Proposed Changes

  • add doc clone
  • update paths

There is some additional cleanup that might be needed since this file doesn't actually exist now - strimzi-topic.yaml. If needed I can take the yaml from the docs and add it as a file in the sample/source folder.

Also, not sure if we want to move the clone further up. I added it where you start applying files.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 31, 2020
@knative-prow-robot
Copy link
Contributor

Hi @mpetason. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2020
@lberk
Copy link
Member

lberk commented Mar 31, 2020

/ok-to-test
Thanks for catching this, looks like we were the odd ones out here by specifying a partial path (vs in the same directory).

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2020
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

One nit; it looks like this is documenting cloning the repo and then running not from the root but from this directory.

At some point, I think our docs team will have a standard way of presenting these (run from root, run from directory, or copy and create files), but this seems fine for now.

cd knative-docs/docs/eventing/samples/kafka/source
```

2. Build the Event Display Service (`even-display.yaml`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Build the Event Display Service (`even-display.yaml`)
2. Build the Event Display Service (`event-display.yaml`)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is "building" the event-display program anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks, missed this, I'll make an update and fix it.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mpetason

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 6ecf46e into knative:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants