-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added clone of docs to steps and updated paths #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clone of docs to steps and updated paths #2355
Conversation
|
Hi @mpetason. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
One nit; it looks like this is documenting cloning the repo and then running not from the root but from this directory.
At some point, I think our docs team will have a standard way of presenting these (run from root, run from directory, or copy and create files), but this seems fine for now.
| cd knative-docs/docs/eventing/samples/kafka/source | ||
| ``` | ||
|
|
||
| 2. Build the Event Display Service (`even-display.yaml`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 2. Build the Event Display Service (`even-display.yaml`) | |
| 2. Build the Event Display Service (`event-display.yaml`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this is "building" the event-display program anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks, missed this, I'll make an update and fix it.
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, mpetason The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes readability and matches serving docs where you will clone the docs first so that you are aware of where the files are.
Proposed Changes
There is some additional cleanup that might be needed since this file doesn't actually exist now - strimzi-topic.yaml. If needed I can take the yaml from the docs and add it as a file in the sample/source folder.
Also, not sure if we want to move the clone further up. I added it where you start applying files.