Skip to content

Conversation

@mattmoor
Copy link
Member

Add the install/sample links to the Knative installation instructions.

Add the install/sample links to the Knative installation instructions.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 12, 2020
@knative-prow-robot knative-prow-robot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2020
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update docs/eventing/sources/sources.yaml and rerun

go run docs/eventing/sources/generator/main.go

@mattmoor
Copy link
Member Author

Thanks @evankanderson, TIL that exists :)

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c72b12a into knative:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants