Update Istio version to 1.4.6 #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
nak3
commented
Apr 12, 2020
| [install guide](./README.md) for your specific platform will have those | ||
| instructions. | ||
|
|
||
| For example, the [GKE Install Guide](./Knative-with-GKE.md) includes the |
Contributor
Author
There was a problem hiding this comment.
I have removed this as the specific installation like GKE dcaf0b8 is already removed.
Contributor
|
/lgtm |
Contributor
|
@mattmoor can you please /approve |
docs/install/installing-istio.md
Outdated
| https://istio.io/docs/setup/kubernetes/additional-setup/sidecar-injection/#manual-sidecar-injection | ||
| [3]: https://istio.io/docs/tasks/traffic-management/ingress/secure-ingress-sds/ | ||
| [4]: https://istio.io/docs/tasks/security/mutual-tls/ | ||
| [4]: https://istio.io/pt-br/docs/concepts/security/#mutual-tls-authentication |
Member
There was a problem hiding this comment.
I don't think you need the /pt-br/ language-specific docs (which doesn't seem to work anyway).
Contributor
Author
There was a problem hiding this comment.
Sorry my bad. Removed pt-br.
knative-prow-robot
added
approved
and removed
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, nak3, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of knative/serving#7568
Proposed Changes
This patch updates Istio version to 1.4.6 which is tested CI and
stable version.
/cc @tcnghia