Skip to content

updating to the latest cloudevents sdk - v2.0.0-RC1 #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2020
Merged

updating to the latest cloudevents sdk - v2.0.0-RC1 #2386

merged 4 commits into from
Apr 13, 2020

Conversation

@n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Apr 13, 2020

Fixes #2382

Proposed Changes

  • Update two samples to latest CloudEvents Go SDK version. New version is v2 in rc1.

/cc slinkydeveloper

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 13, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 13, 2020
mattmoor
mattmoor reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

evankanderson
evankanderson reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but switching this to use go mod (without commiting the vendored code) within each sample directory seems like it would be a win.

@evankanderson
Copy link
Member

evankanderson commented Apr 13, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@n3wscott
Copy link
Contributor Author

n3wscott commented Apr 13, 2020

Not for this PR, but switching this to use go mod (without commiting the vendored code) within each sample directory seems like it would be a win.

totally.

@knative-prow-robot knative-prow-robot merged commit fc69d36 into knative:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

+1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@evankanderson evankanderson

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade cloudevents-go to the new SDK

5 participants

@n3wscott @evankanderson @knative-prow-robot @mattmoor @googlebot