Skip to content

Update references to event-display image #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Update references to event-display image #2390

merged 1 commit into from
Apr 20, 2020

Conversation

@antoineco
Copy link
Contributor

@antoineco antoineco commented Apr 14, 2020 •
edited
Loading

Fixes #2389

Proposed Changes

  • Update references to event-display image

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 14, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2020
@antoineco
Copy link
Contributor Author

antoineco commented Apr 14, 2020

/assign @n3wscott

@n3wscott
Copy link
Contributor

n3wscott commented Apr 14, 2020

yikes thanks!
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@antoineco
Copy link
Contributor Author

antoineco commented Apr 15, 2020

/assign grantr

matzew
matzew approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@antoineco
Copy link
Contributor Author

antoineco commented Apr 20, 2020

@matzew looks like we need one of

  • evankanderson
  • mattmoor
  • dprotaso
  • vaikas
  • rgregg
  • mchmarny
  • averikitsch

@lionelvillard
Copy link
Contributor

lionelvillard commented Apr 20, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, lionelvillard, matzew, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 6d4ace4 into knative:master Apr 20, 2020
@antoineco antoineco deleted the update-event-display-img branch May 14, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@n3wscott n3wscott Awaiting requested review from n3wscott

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@grantr grantr

@matzew matzew

@lionelvillard lionelvillard

@n3wscott n3wscott

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Outdated references to event-display image

7 participants

@antoineco @n3wscott @lionelvillard @knative-prow-robot @matzew @grantr @googlebot