Reorder broker docs; add reference to gcp broker #2449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/S
vaikas
reviewed
May 12, 2020
| @@ -0,0 +1,8 @@ | |||
| In the Knative Eventing ecosystem, vendors are welcome to bring their own implementation of Broker | |||
Contributor
There was a problem hiding this comment.
While I totes agree that vendors are welcome, so are other communities not strictly restricted to vendors. I'd prefer to rework the wording to be more inclusive.
Contributor
Author
There was a problem hiding this comment.
Good point! Reworded a little bit.
Contributor
Author
|
BTW, this is how it will look like in docs website:
|
knative-prow-robot
added
size/M
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liu-cong, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
evankanderson
pushed a commit
to evankanderson/docs
that referenced
this pull request
May 14, 2020
Merged
knative-prow-robot
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue-number or description of the problem the PR solves
Proposed Changes
cc @grantr @vaikas