Skip to content

Added HA details to fix #2454 #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 10, 2020
Merged

Added HA details to fix #2454 #2455

merged 6 commits into from
Jun 10, 2020

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented May 12, 2020 •
edited
Loading

Fixes #2454

Proposed Changes

  • Added details about HA and leader election
  • List of currently HA components

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 12, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2020
vagababov
vagababov reviewed May 12, 2020
View reviewed changes
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2020
@abrennan89 abrennan89 force-pushed the HA branch 2 times, most recently from 1c5563b to 89f3fc5 Compare May 13, 2020 17:15
@abrennan89 abrennan89 requested review from pmorie and vagababov and removed request for n3wscott May 13, 2020 17:58
@mattmoor
Copy link
Member

mattmoor commented May 13, 2020

/approve

vagababov
vagababov reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
/cc @tcnghia @nak3 @ZhiminXiang
for the ns,cert and istio controlelrs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
pmorie
pmorie reviewed May 13, 2020
View reviewed changes
@abrennan89
Copy link
Contributor Author

abrennan89 commented May 13, 2020

I'd keep the details about the Istio and Kourier components, and then maybe just have sub-sections for using Kourier, using Istio, and using none of them? @vagababov @pmorie wdyt?

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
vagababov
vagababov reviewed May 14, 2020
View reviewed changes
@abrennan89 abrennan89 mentioned this pull request May 27, 2020
Closed
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2020
evankanderson
evankanderson reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still [WIP]?

@abrennan89 abrennan89 changed the title [WIP] Added HA details to fix #2454 Added HA details to fix #2454 Jun 5, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2020
@abrennan89
Copy link
Contributor Author

abrennan89 commented Jun 5, 2020

/hold

Matt is checking some commands

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@abrennan89 abrennan89 removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. status/blocked triage/needs-eng-input Engineering input is requested kind/question labels Jun 5, 2020
@abrennan89
Copy link
Contributor Author

abrennan89 commented Jun 8, 2020

Is this still [WIP]?

@evankanderson should be good to go now

mattmoor
mattmoor reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5cf0b90 into knative:master Jun 10, 2020
@abrennan89 abrennan89 deleted the HA branch May 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@nak3 nak3 Awaiting requested review from nak3

@tcnghia tcnghia Awaiting requested review from tcnghia

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

@pmorie pmorie Awaiting requested review from pmorie

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

+3 more reviewers

@vagababov vagababov vagababov left review comments

@mattmoor mattmoor mattmoor left review comments

@lionelvillard lionelvillard lionelvillard left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pmorie pmorie

@mattmoor mattmoor

@evankanderson evankanderson

Labels

cla: yes Indicates the PR's author has signed the CLA. kind/serving lgtm Indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/medium size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Create docs on high-availability components and leader election

9 participants

@abrennan89 @mattmoor @vagababov @knative-prow-robot @pmorie @ZhiminXiang @lionelvillard @evankanderson @googlebot