-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Kafka binding documentation #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka binding documentation #2474
Conversation
|
Could we show/include the source snippet used to build the container image you are running? |
Added a line for the kafka publisher, that I have used the code from here. |
vaikas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Few small comments.
| ``` | ||
| 1. Deploy the Apache Kafka cluster | ||
| ``` | ||
| $ kubectl apply -n kafka -f kafka.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have to first download this file? Wonder if it would be better to have this use the here document? Or, maybe add a link to this file?
Also, the step says this will create a namespace, but it actually installs kafka?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the previous step which displays the yaml, i have added "Describe the size of your Apache Kafka installation in kafka.yaml", in the next step we apply this yaml.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: itsmurugappan, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #2401
Proposed Changes
I have assumed that with 0.15 release , KafkaSource manifests will include the crds for KafkaBinding
Also I published kafka-publisher image into my personal repo and have used it in the example, not sure if this is the right thing.