-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added cloudevents sample using rust sdk #2482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cloudevents sample using rust sdk #2482
Conversation
|
/hold I still need to release the sdk 😄 |
|
/assign @mattmoor |
|
Nice! |
| To build the binary, run: | ||
|
|
||
| ```shell | ||
| cargo build --target x86_64-unknown-linux-musl --release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this in a multi-stage Dockerfile as the others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to avoid it here, it's quite complex and rust users don't always prefer this approach since they basically lose all the local compilation caching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought clearing the local compilation caching was sort of the point -- any local compiler hijinks would be ironed out and the result would be reproducible by building in Docker.
I'd also expect that Rustaceans who were familiar with both Rust and containers would probably write their own Dockerfile based on the reference, anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compilation caches in rust in theory are reproducible because they're per exact crate versions. What usually matters to rust users is that you don't want to clean the compilation cache, 10 mins every time for building an image is not nice 😄 Experienced rust devs usually have a remote hosted compilation cache, like this one https://github.com/mozilla/sccache, that then they use in their docker file builds
I'd also expect that Rustaceans who were familiar with both Rust and containers would probably write their own Dockerfile based on the reference, anyway.
I think so, they just need to create a multi stage build starting from debian rust image
|
@mattmoor any idea why the it test fails? |
|
re: tests, a lot have been failing today because (IIUC) a quay outage. Let's see if it's over. /retest |
b0059af to
11ad561
Compare
|
/hold cancel Now we can get this one in |
|
@mattmoor ping |
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a look -- a couple small questions, mostly about whether this is targeted at experienced Rust + container developers, or those who might be new to one or both tools.
| To build the binary, run: | ||
|
|
||
| ```shell | ||
| cargo build --target x86_64-unknown-linux-musl --release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought clearing the local compilation caching was sort of the point -- any local compiler hijinks would be ironed out and the result would be reproducible by building in Docker.
I'd also expect that Rustaceans who were familiar with both Rust and containers would probably write their own Dockerfile based on the reference, anyway.
c844206 to
5117572
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
5117572 to
f2c693f
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Proposed Changes