Skip to content

update ruby and bundle version #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2020
Merged

update ruby and bundle version #2503

merged 4 commits into from
May 27, 2020

Conversation

@xiangshen-dk
Copy link
Contributor

@xiangshen-dk xiangshen-dk commented May 23, 2020

Upgrade Ruby to 2.6 and related libraries.
It also fixes the build issue on GCP Cloud Build if anybody wants to follow the steps below and deploy the sample to GCP Cloud Run:
https://cloud.google.com/run/docs/quickstarts/build-and-deploy#ruby

Proposed Changes

  • Upgrade the base image from 2.5-slim to 2.6-slim
  • Add 'gem install bundler' in the Dockerfile
  • Update the Gemfile.lock

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 23, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 23, 2020

Welcome @xiangshen-dk! It looks like this is your first PR to knative/docs 🎉

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 23, 2020

Hi @xiangshen-dk. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2020
@xiangshen-dk @mattmoor
Update docs/serving/samples/hello-world/helloworld-ruby/Gemfile.lock
c5b249b 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@xiangshen-dk
Copy link
Contributor Author

xiangshen-dk commented May 23, 2020

/assign @RichieEscarez

evankanderson
evankanderson reviewed May 26, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved labels May 26, 2020
@evankanderson
Copy link
Member

evankanderson commented May 26, 2020

It looks like you need to update README.md as well:

sampleconsistency_test.go:97: README.md file is missing line 2 ('FROM ruby:2.6-slim') from file '../../docs/serving/samples/hello-world/helloworld-ruby/Dockerfile'
Additional info:
All files required for running sample apps are checked against README.md, the content of source files should be identical with what's in README.md file, the list of the files to be verified is the same set of files used for running sample apps, they are configured in /test/sampleapp/config.yaml. If an exception is needed the file can be configured to be copied as a separate step in PreCommand such as:

docs/test/sampleapp/config.yaml

Line 4 in 65f7b40

preCommands:

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@xiangshen-dk
Copy link
Contributor Author

xiangshen-dk commented May 27, 2020

/retest

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 27, 2020

@xiangshen-dk: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@evankanderson
Copy link
Member

evankanderson commented May 27, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
evankanderson
evankanderson reviewed May 27, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, xiangshen-dk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ca0a1b3 into knative:master May 27, 2020
rhuss pushed a commit to rhuss/docs that referenced this pull request Jun 2, 2020
@xiangshen-dk @mattmoor @rhuss
update ruby and bundle version (knative#2503)
a9d25aa 
* update ruby and bundle version

* Update docs/serving/samples/hello-world/helloworld-ruby/Gemfile.lock

Co-authored-by: Matt Moore <mattmoor@vmware.com>

* update README

Co-authored-by: Matt Moore <mattmoor@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@vagababov vagababov Awaiting requested review from vagababov

+1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@evankanderson evankanderson

@RichieEscarez RichieEscarez

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xiangshen-dk @knative-prow-robot @evankanderson @mattmoor @googlebot @RichieEscarez