Minor fixes in easy event source tutorial #2512
Conversation
|
/assign @evankanderson |
knative-prow-robot
added
the
size/S
| # Install app dependencies | ||
| # A wildcard is used to ensure both package.json AND package-lock.json are copied | ||
| # where available (npm@5+) | ||
| # A wildcard is used to ensure both package.json AND package-lock.json |
There was a problem hiding this comment.
Should this still have the "are copied where available", or maybe some other wording - "are copied' without adding where available.
There was a problem hiding this comment.
I think it's highly likely that developers are using npm@5 or newer, since npm@5 was released with Node * in 2017.
|
/assign @mpetason |
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
/approve
I'll let @mpetason /lgtm this after his comments.
| # Install app dependencies | ||
| # A wildcard is used to ensure both package.json AND package-lock.json are copied | ||
| # where available (npm@5+) | ||
| # A wildcard is used to ensure both package.json AND package-lock.json |
There was a problem hiding this comment.
I think it's highly likely that developers are using npm@5 or newer, since npm@5 was released with Node * in 2017.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: no
aliok
force-pushed
the
easy_event_source_tutorial_address_comments
branch
from
f79375f to
9de47b1
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
|
@mpetason @evankanderson pushed a new commit for small grammar fix |
|
/lgtm |
* Minor fixes in easy event source tutorial * Grammar fix
5 participants
Fixes #issue-number or description of the problem the PR solves
Proposed Changes