Skip to content

Conversation

@macruzbar
Copy link
Contributor

Fixes issue #2522

Proposed Changes

  • An editorial team
  • A process for the Knative blog
  • Guidelines on how to contribute to the Knative blog

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 29, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 29, 2020
@macruzbar
Copy link
Contributor Author

/assign @macruzbar

@macruzbar
Copy link
Contributor Author

@abrennan89 @evankanderson would like to add you as reviewers to this as well. I'll add this to our agenda for the docs wg meeting on Tuesday

Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, great work overall! 🙂

macruzbar and others added 2 commits June 1, 2020 11:38
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jun 1, 2020
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
@abrennan89
Copy link
Contributor

@macruzbar there seem to be some broken link issues in the PR, and I'm not sure why it still says no CLA if it's referring to my commits, I've definitely signed it and don't have this issue on any other PRs 😕

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, evankanderson, macruzbar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

macruzbar and others added 2 commits June 16, 2020 10:34
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
macruzbar and others added 2 commits June 16, 2020 10:35
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@macruzbar
Copy link
Contributor Author

/retest

@mattmoor
Copy link
Member

@googlebot I signed it!

@mattmoor
Copy link
Member

@googlebot I fixed it!

@mattmoor
Copy link
Member

@googlebot rescan

@grantr grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 16, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@grantr
Copy link
Contributor

grantr commented Jun 16, 2020

Authors:

All have signed the CLA.

@macruzbar macruzbar changed the title Draft of blogging guidelines for Knative Blogging guidelines for Knative - Ready to publish Jun 17, 2020
@macruzbar
Copy link
Contributor Author

/retest

@knative-prow-robot
Copy link
Contributor

@macruzbar: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check 3e8e1b9 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abrennan89 abrennan89 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@mattmoor
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@knative-prow-robot knative-prow-robot merged commit 711e17e into knative:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants