-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Blogging guidelines for Knative - Ready to publish #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @macruzbar |
|
@abrennan89 @evankanderson would like to add you as reviewers to this as well. I'll add this to our agenda for the docs wg meeting on Tuesday |
abrennan89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, great work overall! 🙂
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
|
@macruzbar there seem to be some broken link issues in the PR, and I'm not sure why it still says no CLA if it's referring to my commits, I've definitely signed it and don't have this issue on any other PRs 😕 |
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, evankanderson, macruzbar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
|
/retest |
|
@googlebot I signed it! |
|
@googlebot I fixed it! |
|
@googlebot rescan |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
Authors:
All have signed the CLA. |
|
/retest |
|
@macruzbar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Fixes issue #2522
Proposed Changes