Skip to content

Add load balancing docs #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 14, 2021
Merged

Add load balancing docs #2559

merged 11 commits into from
Jan 14, 2021

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jun 8, 2020

Fixes #2477

Proposed Changes

  • Add Load balancing section under Serving components
  • Moved TBC docs into this dir

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 8, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2020
@abrennan89 abrennan89 removed request for dprotaso and tcnghia June 8, 2020 18:47
@abrennan89
Copy link
Contributor Author

abrennan89 commented Jun 8, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2020
@mattmoor
Copy link
Member

mattmoor commented Jun 8, 2020

/approve
/hold

For stage-docs

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2020
abrennan89
abrennan89 commented Jun 8, 2020
View reviewed changes
@abrennan89 abrennan89 linked an issue Jun 9, 2020 that may be closed by this pull request
Productionize and public target burst capacity document. #2375
Closed
@abrennan89 abrennan89 force-pushed the 2477 branch 3 times, most recently from 0469ea7 to eb48f61 Compare June 9, 2020 16:02
vagababov
vagababov reviewed Jun 9, 2020
View reviewed changes
@abrennan89 abrennan89 requested a review from vagababov June 10, 2020 13:24
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abrennan89,mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abrennan89 abrennan89 added this to the v0.18.0 milestone Sep 10, 2020
@abrennan89 abrennan89 requested a review from mpetason September 10, 2020 17:27
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2020
@abrennan89 abrennan89 requested review from tcnghia and vagababov and removed request for RichieEscarez December 3, 2020 18:15
@abrennan89 abrennan89 modified the milestones: v0.18.0, v0.20.0 Dec 3, 2020
@abrennan89
Copy link
Contributor Author

abrennan89 commented Dec 3, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020
vagababov
vagababov reviewed Dec 3, 2020
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it seems sometimes we spell Activator and sometimes activator probably has to be consistent?

docs/serving/load-balancing/_index.md

You can configure load balancing on Knative, by placing the _Activator service_ in the request path to act as a load balancer.

**NOTE:** To do this, you must first ensure that individual pod addressability is enabled.
Copy link
Contributor

@vagababov vagababov Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work, ...
Since you can put Activator in the request path, just the load balancing will be whatever underlying transport is (mesh provider most likely).

Copy link
Contributor Author

@abrennan89 abrennan89 Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do we actually need this note at all?
If a user needs to do something here maybe we should add that procedure or link to it to make it clear?

vagababov
vagababov reviewed Dec 3, 2020
View reviewed changes
@abrennan89 abrennan89 requested a review from vagababov December 4, 2020 15:33
@abrennan89
Copy link
Contributor Author

abrennan89 commented Dec 4, 2020

@vagababov updated most things except the one comment about that note, PTAL

@tcnghia tcnghia dismissed their stale review January 4, 2021 20:02

comment addressed

@abrennan89 abrennan89 modified the milestones: v0.20.0, Backlog Jan 14, 2021
vagababov
vagababov reviewed Jan 14, 2021
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@knative-prow-robot knative-prow-robot merged commit 64d6756 into knative:master Jan 14, 2021
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
@abrennan89 @RichieEscarez
Add load balancing docs (knative#2559)
856caf4 
* [WIP] Add load balancing docs

* feedback from vagababov

* fix link

* review feedback and removed README

* minor tweaks and improvements

* minor tweaks, formatting

* fixing links

* removed note

* fix link, default values

* review updates

* review updates
@abrennan89 abrennan89 deleted the 2477 branch May 3, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpetason mpetason Awaiting requested review from mpetason

@tcnghia tcnghia Awaiting requested review from tcnghia

2 more reviewers

@vagababov vagababov vagababov left review comments

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tcnghia tcnghia

@vagababov vagababov

@mpetason mpetason

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Add docs for load balancing Productionize and public target burst capacity document.

7 participants

@abrennan89 @mattmoor @knative-prow-robot @tcnghia @vagababov @mpetason @googlebot