-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Template for verifying AutoTLS was moved #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auto TLS verification used the `autoscale-go` sample, but it was moved in #2439, and not updated here.
|
Welcome @zevisert! It looks like this is your first PR to knative/docs 🎉 |
|
Hi @zevisert. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR is against |
|
/ok-to-test |
|
Usually updates happen with the main branch, I'm not sure if we should target the release or the main branch. After we get an update on that this should get a lgtm or a request to open a new PR. We'll have to wait for someone from OWNERS to weigh in. |
|
/assign @evankanderson |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, zevisert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Auto TLS verification used the
autoscale-gosample, but it was moved in #2439, and not updated here.Fixes #issue-number or description of the problem the PR solves
Proposed Changes