Skip to content

Conversation

@zevisert
Copy link

Auto TLS verification used the autoscale-go sample, but it was moved in #2439, and not updated here.

Fixes #issue-number or description of the problem the PR solves

  • Didn't find any. I came from the documentation's "View / Edit this page" link

Proposed Changes

  • Update the link to the deployment template for verifying auto-tls is correctly configured

Auto TLS verification used the `autoscale-go` sample, but it was moved in #2439, and not updated here.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 19, 2020
@knative-prow-robot
Copy link
Contributor

Welcome @zevisert! It looks like this is your first PR to knative/docs 🎉

@knative-prow-robot
Copy link
Contributor

Hi @zevisert. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2020
@zevisert
Copy link
Author

This PR is against release-0.15 since that was the default, given the "View / Edit this page" link taking me to the markdown doc that's published for v0.15, if I should actually open this against master, let me know!

@mpetason
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2020
@mpetason
Copy link
Contributor

Usually updates happen with the main branch, I'm not sure if we should target the release or the main branch. After we get an update on that this should get a lgtm or a request to open a new PR. We'll have to wait for someone from OWNERS to weigh in.

@mpetason
Copy link
Contributor

/assign @evankanderson

@dprotaso
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, zevisert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot knative-prow-robot merged commit 42d6180 into knative:release-0.15 Jun 22, 2020
@zevisert zevisert deleted the patch-1 branch June 22, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants