Skip to content

Document installing Eventing Sugar Controller #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2020
Merged

Document installing Eventing Sugar Controller #2647

merged 3 commits into from
Jul 6, 2020

Conversation

@n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Jul 6, 2020

Proposed Changes

  • Document the install of the Eventing Sugar Controller
  • Update the annotation for Knative Eventing Injection for namespaces in the mainline get started docs.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 6, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 6, 2020
@n3wscott n3wscott mentioned this pull request Jul 6, 2020
Merged
vaikas
vaikas reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! couple of small changes and I think just overall there should only be one place where we show how to install the eventing, it has resulted in bugs because they have drifted.

docs/eventing/getting-started.md
To complete this guide, you will need the following installed and running:

- A [Kubernetes cluster](https://kubernetes.io/docs/concepts/cluster-administration/cluster-administration-overview/) running v1.15 or higher.
- A
Copy link
Contributor

@vaikas vaikas Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this whole installation bit here and just point to any-kubernetes-cluster.md. They have drifted in the past.

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 6, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 6, 2020

I'll clean up the install section in a follow on PR.
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jul 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9025e29 into knative:master Jul 6, 2020
@vaikas vaikas mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@nachocano nachocano Awaiting requested review from nachocano

2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@vaikas vaikas vaikas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vaikas vaikas

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@n3wscott @vaikas @knative-prow-robot @mattmoor @googlebot