Skip to content

Conversation

@vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 6, 2020

We currently have two sets of installation instructions for Eventing. This PR removes the section in getting started and simply points to the main install instructions.

Proposed Changes

  • Remove parallel installation instructions for eventing. Point to shared instructions instead.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 6, 2020
@knative-prow-robot knative-prow-robot added approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2020
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 70f3d2a into knative:master Jul 6, 2020
@vaikas vaikas deleted the remove-separate-install branch December 7, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants