Skip to content

Conversation

@vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 7, 2020

Change few examples from v1alpha1/v1beta to v1.

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 7, 2020
@knative-prow-robot knative-prow-robot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2020
@knative-prow-robot
Copy link
Contributor

@vaikas: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check f7b8a45 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 80f7c12 into knative:master Jul 7, 2020
@vaikas vaikas deleted the more-v1alpha1-updates branch July 7, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants