Skip to content

Conversation

@pierDipi
Copy link
Member

Fixes #2759

Proposed Changes

  • Document trigger.spec.subscriber type and usage with a particular path

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2020
@pierDipi
Copy link
Member Author

/cc @matzew

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@vaikas
Copy link
Contributor

vaikas commented Aug 19, 2020

/approve
Thanks for doing this!!!

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpetason
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@knative-prow-robot knative-prow-robot merged commit 4d2c894 into knative:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document trigger.spec.subscriber type and usage with a particular path

5 participants