-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adding a section about new releases blog #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abrennan89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions, otherwise lgtm
Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Currently, this page is hidden and viewable from only here in this folder from the GitHub repo. It does not get published to knative.dev but is that desired? We previously put all contributor details/instructions in the knative/community repo (which gets published under the Community section in knative.dev here). If we do want this info publicly visible, we can copy this info to a file over there under the /docs folder and then add a link in this README to crosslink and people to the info? Related: knative/community#205 (comment) |
|
Verified that both authors (@macruzbar and @abrennan89) have previously signed the CLA. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Hi @RichieEscarez thank you for your comment. I read your comment in the PR you shared as well, and I think you are raising a good point. The logic I followed is from my training in open leadership at Mozilla, where they encourage to estate in a README.md file the purpose of the folder / repo that that file is in, and how to contribute to that directory. This is what inspired me to add these contribution guidelines here. I do think, however, that we need to give all these avenues for contribution more visibility in CONTRIBUTING.md file, and possibly, also on the README.md file on the Community repo. I think adding a link with a brief text about the different ways of contributing could be a good idea, as it gives appropriate framing to the new links added. Let me know if you would be able to take care of this; otherwise, I can take care of it towards the end of the week. |
Sounds good. I too am busy and wont be able to address this until possibly later than that so I'll leave this in your hands. Let's work out a plan (next Docs WG meeting?) for all the various files and figure out how to get "what" into the site and "where" with cross linking, etc (and then write it all down somewhere too - my current priority is documenting the site publishing mechanisms). Thanks @macruzbar ! |
Co-authored-by: Mike Petersen <mpetason@gmail.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@macruzbar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
this is ready for approval @RichieEscarez @abrennan89 @mpetason |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
abrennan89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, macruzbar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1880 or description of the problem the PR solves
Proposed Changes