Skip to content

Conversation

@macruzbar
Copy link
Contributor

@macruzbar macruzbar commented Sep 9, 2020

Fixes #1880 or description of the problem the PR solves

Proposed Changes

  • Added a section to the blogging guidelines that addresses blogs about releases and new features

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2020
@knative-prow-robot knative-prow-robot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2020
@macruzbar macruzbar changed the title Adding a section about new releases blog - Response to [issue 1880](https://github.com/knative/docs/issues/1880) Adding a section about new releases blog Sep 9, 2020
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions, otherwise lgtm

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Sep 9, 2020
@RichieEscarez
Copy link
Contributor

Currently, this page is hidden and viewable from only here in this folder from the GitHub repo. It does not get published to knative.dev but is that desired? We previously put all contributor details/instructions in the knative/community repo (which gets published under the Community section in knative.dev here).

If we do want this info publicly visible, we can copy this info to a file over there under the /docs folder and then add a link in this README to crosslink and people to the info? Related: knative/community#205 (comment)

@RichieEscarez RichieEscarez requested review from RichieEscarez and abrennan89 and removed request for samodell September 9, 2020 23:46
@grantr
Copy link
Contributor

grantr commented Sep 9, 2020

Verified that both authors (@macruzbar and @abrennan89) have previously signed the CLA.

@grantr grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Sep 9, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@macruzbar
Copy link
Contributor Author

Currently, this page is hidden and viewable from only here in this folder from the GitHub repo. It does not get published to knative.dev but is that desired? We previously put all contributor details/instructions in the knative/community repo (which gets published under the Community section in knative.dev here).

If we do want this info publicly visible, we can copy this info to a file over there under the /docs folder and then add a link in this README to crosslink and people to the info? Related: knative/community#205 (comment)

Hi @RichieEscarez thank you for your comment. I read your comment in the PR you shared as well, and I think you are raising a good point. The logic I followed is from my training in open leadership at Mozilla, where they encourage to estate in a README.md file the purpose of the folder / repo that that file is in, and how to contribute to that directory. This is what inspired me to add these contribution guidelines here.

I do think, however, that we need to give all these avenues for contribution more visibility in CONTRIBUTING.md file, and possibly, also on the README.md file on the Community repo. I think adding a link with a brief text about the different ways of contributing could be a good idea, as it gives appropriate framing to the new links added. Let me know if you would be able to take care of this; otherwise, I can take care of it towards the end of the week.

@RichieEscarez
Copy link
Contributor

Currently, this page is hidden and viewable from only here in this folder from the GitHub repo. It does not get published to knative.dev but is that desired? We previously put all contributor details/instructions in the knative/community repo (which gets published under the Community section in knative.dev here).
If we do want this info publicly visible, we can copy this info to a file over there under the /docs folder and then add a link in this README to crosslink and people to the info? Related: knative/community#205 (comment)

Hi @RichieEscarez thank you for your comment. I read your comment in the PR you shared as well, and I think you are raising a good point. The logic I followed is from my training in open leadership at Mozilla, where they encourage to estate in a README.md file the purpose of the folder / repo that that file is in, and how to contribute to that directory. This is what inspired me to add these contribution guidelines here.

I do think, however, that we need to give all these avenues for contribution more visibility in CONTRIBUTING.md file, and possibly, also on the README.md file on the Community repo. I think adding a link with a brief text about the different ways of contributing could be a good idea, as it gives appropriate framing to the new links added. Let me know if you would be able to take care of this; otherwise, I can take care of it towards the end of the week.

Sounds good. I too am busy and wont be able to address this until possibly later than that so I'll leave this in your hands. Let's work out a plan (next Docs WG meeting?) for all the various files and figure out how to get "what" into the site and "where" with cross linking, etc (and then write it all down somewhere too - my current priority is documenting the site publishing mechanisms). Thanks @macruzbar !

Co-authored-by: Mike Petersen <mpetason@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Sep 24, 2020
@knative-prow-robot
Copy link
Contributor

@macruzbar: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check 8d497c7 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@macruzbar macruzbar requested a review from mpetason September 24, 2020 22:08
@macruzbar
Copy link
Contributor Author

this is ready for approval @RichieEscarez @abrennan89 @mpetason

@grantr grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Sep 24, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, macruzbar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9ea53f2 into knative:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the "releases" section of the Blog

7 participants