Skip to content

Conversation

@julz
Copy link
Contributor

@julz julz commented Sep 25, 2020

Part of knative/serving#9092.

Proposed Changes

  • Documents the new Scale Down Delay feature

/hold till we finish landing the feature

/assign @markusthoemmes @vagababov @abrennan89

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 25, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2020
Scale Down Delay specifies a time window which must pass at reduced concurrency
before a scale-down decision is applied. This can be useful, for example, to
keep containers around for a configurable duration to avoid a cold start
penalty if new requests come in. Unlike setting a Lower Bound, the revision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
penalty if new requests come in. Unlike setting a Lower Bound, the revision
penalty if new requests come in. Unlike setting a lower bound, the revision

@vagababov
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@abrennan89
Copy link
Contributor

/lgtm
/approve
For whenever you remove the hold 😉 thanks @julz

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@julz
Copy link
Contributor Author

julz commented Sep 30, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2020
@knative-prow-robot knative-prow-robot merged commit 8db736a into knative:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants