Add tested Istio version for clarity #2872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
size/XS
Contributor
|
/assign @ZhiminXiang @JRBANCEL I think @ZhiminXiang and @JRBANCEL are familiar with recent tested Istio version. |
mattmoor
reviewed
Sep 30, 2020
docs/install/installing-istio.md
Outdated
Comment on lines
25
to
27
| The current known-to-be-stable version of Istio tested in conjunction with Knative is **v1.5.7**. | ||
| Versions in the 1.5 line above **v1.5.4** should generally be fine too. | ||
| Versions above the 1.5 line are under test but have not stabilized yet. |
Member
There was a problem hiding this comment.
yea. currently this is 1.4.10. The plan is to bump to Istio 1.7 soon.
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We've been asked for "which version of Istio is actually supported" multiple times so I feel like we should clarify this in our docs and update accordingly once new versions stabilize for us.