Additional eventing sample edits #2930

vmexalien · 2020-10-13T23:21:09Z

Fixes #2704

Proposed Changes

enhancements to docs for consistency and style

Co-Authored-By: Matt Moore <mattmoor@vmware.com>

google-cla · 2020-10-13T23:21:17Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

knative-prow-robot · 2020-10-13T23:21:22Z

Welcome @vmexalien! It looks like this is your first PR to knative/docs 🎉

knative-prow-robot · 2020-10-13T23:21:22Z

Hi @vmexalien. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mpetason · 2020-10-14T15:47:14Z

docs/eventing/samples/helloworld/helloworld-python/README.md

+    Flask==1.1.1
+    ```
+1. In your project directory, create a file named `Dockerfile` and copy the code
+   block below into it. For detailed instructions on dockerizing a Go app, see


Maybe we should replace the "dockerizing a go app" section with something related to Python, or possibly just remove the line related to Go?

docs/eventing/samples/helloworld/helloworld-python/README.md

mpetason · 2020-10-14T15:50:15Z

docs/eventing/samples/helloworld/helloworld-python/README.md

+        kubectl --namespace knative-samples get trigger helloworld-python
+        ```
+## Send and verify CloudEvents
+Once you have deployed the application and verified that the namespace, sample application and trigger are ready, let's send a CloudEvent.


Suggested change

Once you have deployed the application and verified that the namespace, sample application and trigger are ready, let's send a CloudEvent.

Once you have deployed the application and verified that the namespace, sample application, and trigger are ready, let's send a CloudEvent.

@mpetason I like what you have added for punctuation, but for consistency, 'let's' should not be used.

Better put would be - "Once you have deployed the application and verified that the namespace, sample application, and trigger are ready, a CloudEvent can be sent."

Co-authored-by: Mike Petersen <mpetason@gmail.com>

google-cla · 2020-10-14T15:55:10Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mpetason · 2020-10-14T18:03:00Z

@googlebot I consent

/ok-to-test

google-cla · 2020-10-14T18:03:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mpetason · 2020-10-14T18:05:00Z

The CLA issue happens when you pull in changes from someone else. I signed the CLA with a different email address associated with ibm - so co-authoring as the same user that I use to make comments breaks it.

grantr · 2020-10-14T22:50:02Z

I looked at CLA status. vmexalien and axsaucedo are both recorded as signing the CLA. mpetason is not but consented above.

I signed the CLA with a different email address associated with ibm - so co-authoring as the same user that I use to make comments breaks it.

You can sign the CLA with your github-associated email too, then you'll be covered both ways.

docs/eventing/samples/helloworld/helloworld-python/README.md

abrennan89

Thanks @vmexalien, just some suggestions

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

google-cla · 2020-12-08T16:01:49Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

google-cla · 2020-12-08T16:02:09Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

google-cla · 2020-12-08T16:02:58Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-08T16:03:09Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

abrennan89 · 2021-02-01T21:23:55Z

/lgtm

@grantr can you fix the CLA please

abrennan89 · 2021-02-17T22:05:56Z

@googlebot I consent.

google-cla · 2021-02-17T22:06:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

knative-prow-robot · 2021-02-17T22:08:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, vmexalien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~docs/eventing/OWNERS~~ [abrennan89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

grantr · 2021-02-17T22:13:46Z

All authors have (still) consented.

abrennan89 · 2021-02-17T22:30:43Z

/retest

* Added Python Knative Eventing Helloworld Example * Update docs/eventing/samples/helloworld/helloworld-python/Dockerfile Co-Authored-By: Matt Moore <mattmoor@vmware.com> * Update docs/eventing/samples/helloworld/helloworld-python/Dockerfile Co-Authored-By: Matt Moore <mattmoor@vmware.com> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-Authored-By: Matt Moore <mattmoor@vmware.com> * Apply suggestions from code review Co-Authored-By: Matt Moore <mattmoor@vmware.com> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Mike Petersen <mpetason@gmail.com> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com> Co-authored-by: Alejandro Saucedo <axsauze@gmail.com> Co-authored-by: Matt Moore <mattmoor@vmware.com> Co-authored-by: Mike Petersen <mpetason@gmail.com> Co-authored-by: Grant Rodgers <grantr@gmail.com> Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

axsaucedo and others added 5 commits March 11, 2020 15:13

Added Python Knative Eventing Helloworld Example

68ddf1b

Update docs/eventing/samples/helloworld/helloworld-python/Dockerfile

8de32ce

Co-Authored-By: Matt Moore <mattmoor@vmware.com>

Update docs/eventing/samples/helloworld/helloworld-python/Dockerfile

ba7ce92

Co-Authored-By: Matt Moore <mattmoor@vmware.com>

Update docs/eventing/samples/helloworld/helloworld-python/README.md

ea3da45

Co-Authored-By: Matt Moore <mattmoor@vmware.com>

Apply suggestions from code review

82c085e

Co-Authored-By: Matt Moore <mattmoor@vmware.com>

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2020

google-cla bot added the cla: no Indicates the PR's author has not signed the CLA. label Oct 13, 2020

knative-prow-robot requested review from grantr and matzew October 13, 2020 23:21

knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2020

mpetason reviewed Oct 14, 2020

View reviewed changes

Update docs/eventing/samples/helloworld/helloworld-python/README.md

5b75800

Co-authored-by: Mike Petersen <mpetason@gmail.com>

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2020

grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 14, 2020

vmexalien mentioned this pull request Nov 5, 2020

Fix review comments from #2299 #2704

Closed

Merge branch 'master' into additional_eventing_sample_edits

0e25c0b

knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2020

abrennan89 reviewed Dec 4, 2020

View reviewed changes

docs/eventing/samples/helloworld/helloworld-python/README.md Outdated Show resolved Hide resolved

abrennan89 reviewed Dec 4, 2020

View reviewed changes

docs/eventing/samples/helloworld/helloworld-python/README.md Outdated Show resolved Hide resolved

abrennan89 suggested changes Dec 4, 2020

View reviewed changes

Update docs/eventing/samples/helloworld/helloworld-python/README.md

70d5117

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 8, 2020

Update docs/eventing/samples/helloworld/helloworld-python/README.md

c1cd7d4

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

vmexalien and others added 2 commits December 8, 2020 10:02

Update docs/eventing/samples/helloworld/helloworld-python/README.md

32db7de

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

Update docs/eventing/samples/helloworld/helloworld-python/README.md

6d93647

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2020

knative-prow-robot assigned abrennan89 Feb 1, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021

abrennan89 approved these changes Feb 17, 2021

View reviewed changes

knative-prow-robot added the approved label Feb 17, 2021

grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Feb 17, 2021

knative-prow-robot merged commit bbfbbad into knative:master Feb 17, 2021

	Once you have deployed the application and verified that the namespace, sample application and trigger are ready, let's send a CloudEvent.
	Once you have deployed the application and verified that the namespace, sample application, and trigger are ready, let's send a CloudEvent.

Additional eventing sample edits #2930

Additional eventing sample edits #2930

Uh oh!

Conversation

vmexalien commented Oct 13, 2020

Proposed Changes

Uh oh!

google-cla bot commented Oct 13, 2020

Uh oh!

knative-prow-robot commented Oct 13, 2020

Uh oh!

knative-prow-robot commented Oct 13, 2020

Uh oh!

mpetason Oct 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mpetason Oct 14, 2020

Choose a reason for hiding this comment

Uh oh!

vmexalien Oct 15, 2020

Choose a reason for hiding this comment

Uh oh!

google-cla bot commented Oct 14, 2020

Uh oh!

mpetason commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Oct 14, 2020

Uh oh!

mpetason commented Oct 14, 2020

Uh oh!

grantr commented Oct 14, 2020

Uh oh!

Uh oh!

Uh oh!

abrennan89 left a comment

Choose a reason for hiding this comment

Uh oh!

google-cla bot commented Dec 8, 2020

Uh oh!

google-cla bot commented Dec 8, 2020

Uh oh!

google-cla bot commented Dec 8, 2020

Uh oh!

google-cla bot commented Dec 8, 2020

Uh oh!

abrennan89 commented Feb 1, 2021

Uh oh!

abrennan89 commented Feb 17, 2021

Uh oh!

google-cla bot commented Feb 17, 2021

Uh oh!

knative-prow-robot commented Feb 17, 2021

Uh oh!

grantr commented Feb 17, 2021

Uh oh!

abrennan89 commented Feb 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mpetason commented Oct 14, 2020 •

edited

Loading