Add description on how to configure each ingress for knative serving #3025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/L
mpetason
reviewed
Nov 12, 2020
Comment on lines
542
to
543
| In the case of the provided `helloworld-go` sample application, the output | ||
| should, using the default configuration, be: |
Contributor
There was a problem hiding this comment.
Suggested change
| In the case of the provided `helloworld-go` sample application, the output | |
| should, using the default configuration, be: | |
| In the case of the provided `helloworld-go` sample application, using the default configuration, the output should be: |
Member
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
/approve
I'll let Mike do the /lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 6, 2021
…native#3025) * Add description on how to configure each ingress for knative serving * Rephrase the sentence in a correct order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes