Skip to content

fix broken url in docs #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

fix broken url in docs #3051

merged 1 commit into from
Dec 16, 2020

Conversation

@saintmalik
Copy link
Contributor

@saintmalik saintmalik commented Nov 20, 2020

Summary

Easy navigation and easy reading for others

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 20, 2020
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 20, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 20, 2020

Welcome @saintmalik! It looks like this is your first PR to knative/docs 🎉

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 20, 2020

Hi @saintmalik. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2020
@mpetason
Copy link
Contributor

mpetason commented Dec 3, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2020
@mpetason
Copy link
Contributor

mpetason commented Dec 3, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@abrennan89
Copy link
Contributor

abrennan89 commented Dec 16, 2020

/hold
/approve

@mpetason I wasn't able to test this, but if it works OK for you feel free to merge.
@saintmalik could you also add this change to the master branch please so that it appears for future releases?

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, saintmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpetason
Copy link
Contributor

mpetason commented Dec 16, 2020

/unhold

Looks like it should work

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020
@knative-prow-robot knative-prow-robot merged commit eadedaa into knative:release-0.19 Dec 16, 2020
@saintmalik
Copy link
Contributor Author

saintmalik commented Dec 16, 2020

/hold
/approve

@mpetason I wasn't able to test this, but if it works OK for you feel free to merge.
@saintmalik could you also add this change to the master branch please so that it appears for future releases?

@abrennan89 it did work, I checked the site now after the merge.

Also should I create a new pull request for this changes against the master branch now?

@saintmalik
Copy link
Contributor Author

saintmalik commented Dec 16, 2020

/unhold

Looks like it should work

Its working bro

@abrennan89
Copy link
Contributor

abrennan89 commented Dec 16, 2020 •
edited
Loading

Also should I create a new pull request for this changes against the master branch now?

Yes please, you can assign it / tag me for a review too 🙂

@abrennan89 abrennan89 added this to the v0.20.0 milestone Dec 16, 2020
@saintmalik
Copy link
Contributor Author

saintmalik commented Dec 16, 2020

Also should I create a new pull request for this changes against the master branch now?

Yes please, you can assign it / tag me for a review too 🙂

Done, check here #3106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@mpetason mpetason

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@saintmalik @knative-prow-robot @mpetason @abrennan89