Skip to content

Conversation

@xtreme-sameer-vohra
Copy link
Contributor

Proposed Changes

fix url "tutorial on writing a Source with a Receive Adapter" section to reflect current folder structure.

Note to reviewer

this should get cherry-picked to the current release branch 0.19 as well as its broken on the live site

- fix url "tutorial on writing a Source with a Receive Adapter" section

Signed-off-by: Sameer Vohra <vsameer@vmware.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 6, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2020
@abrennan89 abrennan89 requested a review from mpetason December 16, 2020 20:32
@abrennan89 abrennan89 added this to the v0.20.0 milestone Dec 16, 2020
@xtreme-sameer-vohra
Copy link
Contributor Author

Hey @abrennan89
Is there anything I could do to move this PR ahead ? This addresses the broken link on the live site.

Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @xtreme-sameer-vohra !

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, xtreme-sameer-vohra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5d512be into knative:master Jan 8, 2021
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
…#3084)

- fix url "tutorial on writing a Source with a Receive Adapter" section

Signed-off-by: Sameer Vohra <vsameer@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants