Skip to content

Add documentation to sinkbinding modes #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Add documentation to sinkbinding modes #3101

merged 1 commit into from
Dec 17, 2020

Conversation

@lberk
Copy link
Member

@lberk lberk commented Dec 10, 2020

Proposed Changes

  • Document the sinkbinding modes and their side effects in relation to namespaces and labels

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 10, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2020
abrennan89
abrennan89 reviewed Dec 16, 2020
View reviewed changes
abrennan89
abrennan89 suggested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lberk just some edits 🙂

@abrennan89 abrennan89 self-assigned this Dec 16, 2020
@abrennan89 abrennan89 added this to the v0.20.0 milestone Dec 16, 2020
@google-cla
Copy link

google-cla bot commented Dec 16, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 16, 2020
@lberk
Copy link
Member Author

lberk commented Dec 16, 2020

awesome, thanks @abrennan89! (though I think that means I just annoyed cla-bot and you might have to consent to me having used your edit?)

@lberk
Copy link
Member Author

lberk commented Dec 16, 2020

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Dec 16, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@abrennan89
Copy link
Contributor

abrennan89 commented Dec 17, 2020

@googlebot I consent

@google-cla
Copy link

google-cla bot commented Dec 17, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@abrennan89
Copy link
Contributor

abrennan89 commented Dec 17, 2020

@lberk I think repushing the PR also works 🙂

abrennan89
abrennan89 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lberk lberk force-pushed the document-sinkbinding-modes branch from ee98587 to b75cceb Compare December 17, 2020 14:55
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@google-cla
Copy link

google-cla bot commented Dec 17, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@abrennan89
Copy link
Contributor

abrennan89 commented Dec 17, 2020

Idk why this isn't working 😖 @RichieEscarez can you please take a look in case it needs to be added manually? Are we missing something here?

@RichieEscarez
Copy link
Contributor

RichieEscarez commented Dec 17, 2020 •
edited
Loading

@abrennan89 are you on a different machine or maybe changed your local config (ie private account settings)? The CLA is failing because of this email: 40172997+abrennan89@users.noreply.github.com.

@RichieEscarez RichieEscarez added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Dec 17, 2020
@abrennan89
Copy link
Contributor

abrennan89 commented Dec 17, 2020

@RichieEscarez yes and no, my machine died so it had to be resurrected and reinstalled everything etc. Any idea how to fix that?

@lberk @abrennan89
Add documentation to sinkbinding modes
6f8afd5 
Update docs/eventing/sources/sinkbinding.md

As suggested

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
@lberk lberk force-pushed the document-sinkbinding-modes branch from b75cceb to 6f8afd5 Compare December 17, 2020 19:50
@google-cla
Copy link

google-cla bot commented Dec 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 17, 2020
@lberk
Copy link
Member Author

lberk commented Dec 17, 2020

@googlebot I consent.

@abrennan89 I edited the commit message to fix the email from github's auto-commit, sorry about that!

@google-cla
Copy link

google-cla bot commented Dec 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@abrennan89
Copy link
Contributor

abrennan89 commented Dec 17, 2020

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Dec 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@abrennan89
Copy link
Contributor

abrennan89 commented Dec 17, 2020

/lgtm

Please cla-bot 😂

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@RichieEscarez RichieEscarez added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Dec 17, 2020
@knative-prow-robot knative-prow-robot merged commit 57f33d3 into knative:master Dec 17, 2020
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
@lberk @abrennan89 @RichieEscarez
Add documentation to sinkbinding modes (knative#3101)
e799373 
Update docs/eventing/sources/sinkbinding.md

As suggested

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

1 more reviewer

@abrennan89 abrennan89 abrennan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abrennan89 abrennan89

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lberk @abrennan89 @knative-prow-robot @RichieEscarez