Skip to content

Conversation

@abrennan89
Copy link
Contributor

Fixes #3154

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 17, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved labels Feb 17, 2021
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1d4a918 into knative:master Feb 17, 2021
@abrennan89
Copy link
Contributor Author

/cherrypick release-0.18

@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #3255

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor Author

/cherrypick release-0.19

@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #3256

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor Author

/cherrypick release-0.20

@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #3257

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
* Fix typo in pingsource docs

* Fix typo in pingsource docs
yangyunfeng007 pushed a commit to yangyunfeng007/docs that referenced this pull request Mar 8, 2021
* Fix typo in pingsource docs

* Fix typo in pingsource docs
@abrennan89 abrennan89 deleted the 3154 branch May 3, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PingSource(docs/eventing/sources/pingsource.md) source schedule confusion

3 participants