Skip to content

Conversation

@nak3
Copy link
Contributor

@nak3 nak3 commented Feb 18, 2021

Fixes #3222

config-domain.yaml has a symlink before https://github.com/knative/serving/blob/release-0.17/config/config-domain.yaml, but the symlink was removed.

So this patch fixes the yaml path to the original file https://github.com/knative/serving/blob/master/config/core/configmaps/domain.yaml.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 18, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2021
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9e15174 into knative:master Feb 18, 2021
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
yangyunfeng007 pushed a commit to yangyunfeng007/docs that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting up a custom domain(docs/serving/using-a-custom-domain.md)

3 participants