Skip to content

Fix typo #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2018
Merged

Fix typo #476

merged 1 commit into from
Oct 29, 2018

Conversation

@danmcp
Copy link
Contributor

@danmcp danmcp commented Oct 26, 2018

No description provided.

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2018
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 26, 2018

Hi @danmcp. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RichieEscarez
RichieEscarez approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2018
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmcp, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RichieEscarez RichieEscarez added approved and removed approved needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2018
@knative-prow-robot knative-prow-robot merged commit 616e5e3 into knative:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgregg rgregg Awaiting requested review from rgregg

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@RichieEscarez RichieEscarez RichieEscarez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RichieEscarez RichieEscarez

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danmcp @knative-prow-robot @RichieEscarez