Skip to content

Conversation

@mit-mit
Copy link
Contributor

@mit-mit mit-mit commented Aug 4, 2022

Update all Dart sample files to follow the latest Dart server template (dart create -t server-shelf).

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dfdce68
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/62f3f8e3c88cff000858fb7b
😎 Deploy Preview https://deploy-preview-5159--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 4, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 4, 2022

Welcome @mit-mit! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 4, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 4, 2022

Hi @mit-mit. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mit-mit
Copy link
Contributor Author

mit-mit commented Aug 4, 2022

@jonasfj can you please review?

@mit-mit
Copy link
Contributor Author

mit-mit commented Aug 8, 2022

@jonasfj is on vacation; @kevmoo can you LGTM?

dependencies:
shelf: ^1.0.0
```shell
> create -t server-shelf helloworld-dart
Copy link

@hrishikesh-kadam hrishikesh-kadam Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mit-mit!
dart word seems to be missing in the command.

I came to this PR by traversing the following path -

  1. https://www.cloudskillsboost.google/course_sessions/1402704/labs/187125
    The hyperlink at the end of Task 2

  2. https://cloud.google.com/run/docs/quickstarts
    Click "Build and deploy a service in other languages"

  3. https://cloud.google.com/run/docs/quickstarts/build-and-deploy/deploy-service-other-languages
    Write the sample application -> Two Dart hyperlink

So, someone from the Cloud Team might need to update the above hyperlinks once this goes live.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dart word seems to be missing in the command.

oh, good catch, fixed now

@knative-prow
Copy link

knative-prow bot commented Aug 8, 2022

@kevmoo: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

/ok-to-test
/lgtm

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@abrennan89
Copy link
Contributor

/approve

@knative-prow
Copy link

knative-prow bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, kevmoo, mit-mit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@abrennan89
Copy link
Contributor

@mit-mit any errors reported will need to be fixed before this can merge: https://github.com/knative/docs/runs/7770884752?check_suite_focus=true

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@mit-mit
Copy link
Contributor Author

mit-mit commented Aug 10, 2022

@abrennan89 I fixed the test issue

@abrennan89
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@knative-prow knative-prow bot merged commit a247aa8 into knative:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants