-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Dart sample to latest Dart server template #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Welcome @mit-mit! It looks like this is your first PR to knative/docs 🎉 |
|
Hi @mit-mit. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jonasfj can you please review? |
| dependencies: | ||
| shelf: ^1.0.0 | ||
| ```shell | ||
| > create -t server-shelf helloworld-dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mit-mit!
dart word seems to be missing in the command.
I came to this PR by traversing the following path -
-
https://www.cloudskillsboost.google/course_sessions/1402704/labs/187125
The hyperlink at the end of Task 2 -
https://cloud.google.com/run/docs/quickstarts
Click "Build and deploy a service in other languages" -
https://cloud.google.com/run/docs/quickstarts/build-and-deploy/deploy-service-other-languages
Write the sample application -> Two Dart hyperlink
So, someone from the Cloud Team might need to update the above hyperlinks once this goes live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dart word seems to be missing in the command.
oh, good catch, fixed now
|
@kevmoo: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, kevmoo, mit-mit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mit-mit any errors reported will need to be fixed before this can merge: https://github.com/knative/docs/runs/7770884752?check_suite_focus=true |
|
@abrennan89 I fixed the test issue |
|
/lgtm |
Update all Dart sample files to follow the latest Dart server template (
dart create -t server-shelf).