Skip to content

Adv. install topic - pluggable components #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 26, 2018
Merged

Adv. install topic - pluggable components #542

merged 13 commits into from
Dec 26, 2018

Conversation

@RichieEscarez
Copy link
Contributor

@RichieEscarez RichieEscarez commented Nov 14, 2018 •
edited
Loading

Surface how to install individual Knative v0.2.x components in a separate "custom install" topic.

Open issues/questions that need to be addressed:

  • Describe why or when to choose an Istio alternative?
    • Which package includes automatic sidecar injection?
    • Which package configures for manual sidecar injection?
    • If you configure for manual sidecar injection, any other requirements?
  • When is the label istio-injection=enabled required?
  • Ensure table reflects any dependencies (if you install "eventing" is it required to install "eventing-sources"?)
  • Are all the descriptions for the installation packages accurate?
    • Are they complete? Any dependencies to mention?

GOAL:
Create a standalone document that holds all the complicated and various options for installing Knative components and is separate from the set of "opinionated, host specific install guides".

@samodell will then take this doc (once open issues resolved and merged) and improve the information architecture around all the install guides to make clear that new Knative users should start with the existing guides, and then adv. users should use the steps in this document to customize their installation.

A separate effort is in progress to update the "observability plugin install instructions" - #447

Fixes: #478
Fixes: #295

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2018
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

samodell
samodell reviewed Nov 14, 2018
View reviewed changes
Copy link
Contributor

@samodell samodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, Richie!

samodell
samodell reviewed Nov 15, 2018
View reviewed changes
@RichieEscarez RichieEscarez force-pushed the install-comps branch 4 times, most recently from e9c73bc to b8871e3 Compare November 16, 2018 22:52
@RichieEscarez
Copy link
Contributor Author

RichieEscarez commented Nov 16, 2018

@mattmoor the editing cycle is done and this page is now ready for your review, please!

samodell
samodell reviewed Nov 20, 2018
View reviewed changes
RichieEscarez
RichieEscarez commented Nov 21, 2018
View reviewed changes
@RichieEscarez RichieEscarez force-pushed the install-comps branch 5 times, most recently from 42e3bc2 to 2653494 Compare November 21, 2018 00:46
@samodell samodell mentioned this pull request Nov 21, 2018
Merged
RichieEscarez
RichieEscarez commented Nov 21, 2018
View reviewed changes
mattmoor
mattmoor reviewed Nov 27, 2018
View reviewed changes
mattmoor
mattmoor reviewed Nov 27, 2018
View reviewed changes
mattmoor
mattmoor reviewed Nov 27, 2018
View reviewed changes
@RichieEscarez RichieEscarez force-pushed the install-comps branch 4 times, most recently from 8ea2ee8 to c820806 Compare December 18, 2018 23:31
@RichieEscarez
Copy link
Contributor Author

RichieEscarez commented Dec 18, 2018

Hi all, sorry for the delay (back from vacation)! I'm working towards wrapping this up to unblock #565.

There is one open action item for @tcnghia (validate/lgtm the Istio content) and otherwise we need an overall LGTM. Please take a look and let me know if further change is needed.

@RichieEscarez RichieEscarez force-pushed the install-comps branch 3 times, most recently from bc86328 to 1383ade Compare December 19, 2018 00:21
gyliu513
gyliu513 reviewed Dec 19, 2018
View reviewed changes
Copy link
Contributor

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks @RichieEscarez

tcnghia
tcnghia reviewed Dec 21, 2018
View reviewed changes
Copy link
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some clarifications: the istio-lean.yaml that we provided wasn't to allow the Manual Sidecar Injection option, but mainly for users that wish to use Knative Serving without needing a Service mesh. Users can still do Manual Sidecar Injection but they don't have to in order to use Serving.

@RichieEscarez
Copy link
Contributor Author

RichieEscarez commented Dec 21, 2018

@tcnghia I've recovered all comments to make clearer what istio-lean.yaml provides. Please take a look at my edits and let me if further change is needed. Otherwise, let me know if all the Istio content is LTGM?

@tcnghia
Copy link
Contributor

tcnghia commented Dec 26, 2018

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2018
@knative-prow-robot knative-prow-robot merged commit d04370f into knative:master Dec 26, 2018
RichieEscarez added a commit to RichieEscarez/docs that referenced this pull request Dec 28, 2018
@RichieEscarez
Adv. install topic - pluggable components (knative#542)
9a9678c 
* move all install comps to adv file

* recovering review comments

* filename change

* title update

* There can be multiple components in a knative package

* fix links

* new serving version

* Update install/Knative-custom-install.md

in testing I found that this is not a real namespace so removing

* Update packages in table

* review feedback, 0.2.1 eventing, eventsource lists

* edit Istio steps around admission controller

* fix indentation

* Recover networking related comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

5 more reviewers

@tcnghia tcnghia tcnghia left review comments

@mattmoor mattmoor mattmoor left review comments

@mdemirhan mdemirhan mdemirhan left review comments

@gyliu513 gyliu513 gyliu513 left review comments

@samodell samodell samodell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tcnghia tcnghia

@mattmoor mattmoor

@samodell samodell

Labels

lgtm Indicates that a PR is ready to be merged. priority/high size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/needs-eng-input Engineering input is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update install, introducing individual component install Install docs are very Serving focused.

7 participants

@RichieEscarez @knative-prow-robot @tcnghia @mattmoor @mdemirhan @gyliu513 @samodell