Skip to content

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jun 5, 2023

Proposed Changes

This path documentation about the new field introduce by knative/operator#1227

/cherrypick release-1.10
/cherrypick release-1.9

/cc @houshengbo

@knative-prow knative-prow bot requested a review from houshengbo June 5, 2023 05:58
@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a5ac03
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/647d79926ac5650008c127d9
😎 Deploy Preview https://deploy-preview-5592--knative.netlify.app/docs/install/operator/configuring-serving-cr
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2023
@nak3
Copy link
Contributor Author

nak3 commented Jun 8, 2023

/cc @dprotaso @psschwei

@knative-prow knative-prow bot requested review from dprotaso and psschwei June 8, 2023 04:54
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @houshengbo

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@dprotaso
Copy link
Member

bump @houshengbo

@skonto
Copy link
Contributor

skonto commented Jul 13, 2023

@houshengbo gentle ping.

Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, nak3, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3793ede into knative:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants