Skip to content

Conversation

@evankanderson
Copy link
Member

Fixes at least the 404 page, which currently has asset links to /docs/assets/.... Oddly, many of the other pages somehow continue to work (caches?)

Proposed Changes

  • Fix the site base URL.

@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fd9fc74
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68cada02be14640008e1ac79
😎 Deploy Preview https://deploy-preview-6384--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@knative-prow knative-prow bot requested review from mmejia02 and nainaz September 17, 2025 15:55
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2025
@evankanderson
Copy link
Member Author

Fixes https://deploy-preview-6384--knative.netlify.app/123, does not fix search.

@dprotaso
Copy link
Member

lol the 404 page

Screenshot 2025-09-17 at 12 19 59 PM

@dprotaso
Copy link
Member

/lgtm
/approve

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cf495d6 into knative:main Sep 17, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6385

In response to this:

/lgtm
/approve

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@evankanderson
Copy link
Member Author

evankanderson commented Sep 17, 2025

lol the 404 page

Screenshot 2025-09-17 at 12 19 59 PM

This is because we generate a top-level .nav.yml that looks like:

nav:
- docs
- about
- blog
- community
- Docs: development
- Docs: v1.18-docs
- Docs: v1.17-docs

We could name those other "Docs" sections separately, since we don't surface them in the nav elsewhere...

evankanderson added a commit to evankanderson/docs that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants