Skip to content

Conversation

@evankanderson
Copy link
Member

Fixes lint issues detected in #6405, speeds up docs build

Proposed Changes

  • Fix misspell detected typos in threat model.
  • Exclude vendored, minified typescript from linting.
  • Fix missing newline at EOF in 6 files.
  • Switch from 'git clone' to 'git worktree add', which cuts about 50% of the docs build time on my laptop.

@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit d83f749
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68d5b9cc5f801100086cf3ef
😎 Deploy Preview https://deploy-preview-6407--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@knative-prow knative-prow bot requested review from mmejia02 and nainaz September 25, 2025 19:49
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2025
@dprotaso
Copy link
Member

Confused the build error seems unrelated to your PR

3:49:54 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
3:49:54 PM:     - from: /community/*
      status: 301
      to: /docs/community/
    - from: /docs/help/contributor/*
      status: 301
      to: https://github.com/knative/docs/blob/main/contribute-to-docs/README.md
  redirectsOrigin: config
3:49:54 PM: Build failed due to a user error: Build script returned non-zero exit code: 2

/retest

@evankanderson evankanderson force-pushed the cleanup-lints branch 5 times, most recently from c461ea2 to 6a69653 Compare September 25, 2025 20:58
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2025
@evankanderson
Copy link
Member Author

Confused the build error seems unrelated to your PR

3:49:54 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
3:49:54 PM:     - from: /community/*
      status: 301
      to: /docs/community/
    - from: /docs/help/contributor/*
      status: 301
      to: https://github.com/knative/docs/blob/main/contribute-to-docs/README.md
  redirectsOrigin: config
3:49:54 PM: Build failed due to a user error: Build script returned non-zero exit code: 2

/retest

This was due to the git clone at Netlify not having fetched any recent branch data; it was all very old (release-1.7 era). I added a git fetch --prune origin to the code during CI to keep this up to date.

I do need to figure out why the ./hack/build.sh --strict failed, we shouldn't ignore that one (which seems to be another git worktree complaint).

@evankanderson evankanderson force-pushed the cleanup-lints branch 2 times, most recently from b986ee7 to fa6dd34 Compare September 25, 2025 21:48
@evankanderson
Copy link
Member Author

Okay, I think I fixed the worktree stuff. Netlify and "strict" checks should both now pass.

@dprotaso
Copy link
Member

Okay, I think I fixed the worktree stuff. Netlify and "strict" checks should both now pass.

What was the issue?

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3c6c38b into knative:main Sep 25, 2025
19 checks passed
@evankanderson
Copy link
Member Author

Okay, I think I fixed the worktree stuff. Netlify and "strict" checks should both now pass.

What was the issue?

For some reason, the GitHub action wanted a refspec of origin/$BRANCH, and the netlify issue was needing to run git fetch (but the $BRANCH refspec worked fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants