-
Notifications
You must be signed in to change notification settings - Fork 1.3k
drop port forwarding #6444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
drop port forwarding #6444
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
this simplifies client interaction as we don't require port-fowarding anymore
52b1140
to
fe2efe6
Compare
code-samples/eventing/bookstore-sample-app/start/frontend/config/100-front-end-deployment.yaml
Outdated
Show resolved
Hide resolved
re-opened so we get the github rate limit fix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't finished it yet. Submitting for the first round of review.
code-samples/eventing/bookstore-sample-app/start/slack-sink/application.properties
Outdated
Show resolved
Hide resolved
echo "✅ The node-server is now installed. Please visit http://localhost:8080 to view the bookstore node-server." | ||
echo "⚠️ If you cannot access it, please run 'kubectl port-forward svc/node-server-svc 8080:80' to forward the port to your localhost." | ||
echo "✅ The node-server is now installed. Please visit http://${NODE_SERVER_IP} to view the bookstore node-server." | ||
read -p '🛑 Can you see "Hello World!"? If yes, press ENTER to continue...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we added the reverse proxy, and only using the internal cluster IP for the backend server, user won't be able to directly access the node server backend. Therefore this message need to get updated. Instead, user can visit the bookstore front end page, and see if the status badge has turned green and show "Connected to node server"

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://${NODE_SERVER_IP}
This works since the Kubernetes Service for the node server is of type=LoadBalancer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "" | ||
echo "✅ The node-server is now installed. Please visit http://localhost:8080 to view the bookstore node-server." | ||
echo "⚠️ If you cannot access it, please run 'kubectl port-forward svc/node-server-svc 8080:80' to forward the port to your localhost." | ||
echo "✅ The node-server is now installed. Please visit http://${NODE_SERVER_IP} to view the bookstore node-server." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next comment applies to here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works since the Kubernetes Service for the node server is of type=LoadBalancer
…plication.properties Co-authored-by: Leo Li <36619969+Leo6Leo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished most of the review, beside these comments, the rest looks good. I will be manually follow and run through the tutorial later to make sure content is accurate. Thanks @dprotaso !
echo "✅ The node-server is now installed. Please visit http://localhost:8080 to view the bookstore node-server." | ||
echo "⚠️ If you cannot access it, please run 'kubectl port-forward svc/node-server-svc 8080:80' to forward the port to your localhost." | ||
echo "✅ The node-server is now installed. Please visit http://${NODE_SERVER_IP} to view the bookstore node-server." | ||
read -p '🛑 Can you see "Hello World!"? If yes, press ENTER to continue...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
# Install Camel-K | ||
echo "" | ||
echo "📦 Installing Camel-K..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like $REGISTRY_PORT value cannot be empty here. If it is, the script will exit with error.
error: error parsing STDIN: error converting YAML to JSON: yaml: line 9: mapping values are not allowed in this context
I haven't used the local registry yet, so couldn't comment on this too much. Originally in the old version of tutorial, the remote registry address is requested.
I'm hoping this supplements #6204