Skip to content

Conversation

@evankanderson
Copy link
Member

Absolute links like /docs/... will always link to the current release, even when in older or pre-release version documentation. This switches all (/docs links (except one snippet, which has inclusions at different depths).

At some point, we should probably look at combining the serving and eventing observability documentation (which are now both under "administration"), but I didn't want to blow up the size of this PR.

Proposed Changes

  • Replace (/docs links with relative links within the versioned directory.

@knative-prow knative-prow bot requested review from Leo6Leo and creydr October 29, 2025 17:14
@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit f6cf00e
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/69025f4db54ad400081ffbf0
😎 Deploy Preview https://deploy-preview-6477--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow
Copy link

knative-prow bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@evankanderson
Copy link
Member Author

/hold

I need to check a couple pages before this is ready to merge.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@evankanderson
Copy link
Member Author

It turns out that security-prereqs-images.md was used by previous versions, which was flagged by mkdocs strict. 😁

@evankanderson
Copy link
Member Author

/hold cancel
/assign @dprotaso

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@knative-prow knative-prow bot merged commit 41f00eb into knative:main Oct 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants