Skip to content

allow build on mac #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

allow build on mac #6478

merged 1 commit into from
Oct 29, 2025

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 29, 2025 •
edited
Loading

  • make sure users set GITHUB_TOKEN
  • require gsed on mac
  • if an upstream remote exist use that over origin for branch pulling. This allows gh repo fork flows which sets up origin and upstream remotes

@netlify
Copy link

netlify bot commented Oct 29, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit 858b41f
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/69024c5cbaebcf000888ceb4
😎 Deploy Preview https://deploy-preview-6478--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@knative-prow knative-prow bot requested review from mmejia02 and skonto October 29, 2025 17:18
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2025
evankanderson
evankanderson reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9a3b171 into knative:main Oct 29, 2025
19 checks passed
@dprotaso dprotaso deleted the mac-build branch October 30, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@mmejia02 mmejia02 Awaiting requested review from mmejia02

@skonto skonto Awaiting requested review from skonto

Assignees

@evankanderson evankanderson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dprotaso @evankanderson