Skip to content

Update service.yaml in the gitwebhook sample #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2018
Merged

Update service.yaml in the gitwebhook sample #648

merged 1 commit into from
Dec 11, 2018

Conversation

@yifange
Copy link
Contributor

@yifange yifange commented Dec 9, 2018

Change the image name to match the instructions in README.

@yifange
Update service.yaml in the gitwebhook sample
09e011f 
Change the image name to match the instructions in README.
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2018
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 9, 2018

Hi @yifange. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samodell
Copy link
Contributor

samodell commented Dec 11, 2018

/ok-to-test

@samodell
Copy link
Contributor

samodell commented Dec 11, 2018

/lgtm
/approve

@samodell samodell removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 11, 2018
@samodell
Copy link
Contributor

samodell commented Dec 11, 2018

/retest

@samodell samodell self-assigned this Dec 11, 2018
@samodell
Copy link
Contributor

samodell commented Dec 11, 2018

/test pull-knative-docs-go-coverage

@samodell samodell added approved lgtm Indicates that a PR is ready to be merged. labels Dec 11, 2018
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, yifange

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 11, 2018

@yifange: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-docs-go-coverage 09e011f link /test pull-knative-docs-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot merged commit 7f185c4 into knative:master Dec 11, 2018
samodell pushed a commit to samodell/docs that referenced this pull request Dec 12, 2018
@yifange @samodell
Update service.yaml in the gitwebhook sample (knative#648)
6f94f93 
Change the image name to match the instructions in README.

Creating OWNERS_ALIASES

add OWNERS_ALIASES, update OWNERS to remove labadav
samodell pushed a commit to samodell/docs that referenced this pull request Dec 12, 2018
@yifange @samodell
Update service.yaml in the gitwebhook sample (knative#648)
d588bbe 
Change the image name to match the instructions in README.

Creating OWNERS_ALIASES

add OWNERS_ALIASES, update OWNERS to remove labadav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@mchmarny mchmarny Awaiting requested review from mchmarny

Assignees

@samodell samodell

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yifange @knative-prow-robot @samodell