Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 30, 2025

I noticed the script changes failed a subsequent PR - #6479

Unsure why the deploy preview in the original PR didn't work

Netlify prunes the env variable

2:07:47 AM: The following environment variables have been removed from this build to keep them secret:
2:07:47 AM: - GITHUB_TOKEN

@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 397f9fa
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/69035404c20dda0008eb633e
😎 Deploy Preview https://deploy-preview-6480--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and mmejia02 October 30, 2025 12:03
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2025
@dprotaso
Copy link
Member Author

/assign @evankanderson

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5fb2979 into knative:main Oct 30, 2025
19 checks passed
@dprotaso dprotaso deleted the fix-ci-build branch October 30, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants