-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: add AWS SQS source to README #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @srvaroa. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Galo Navarro <anglorvaroa@gmail.com>
| [ObjectReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#objectreference-v1-core) | ||
| A reference to the object that should receive events. | ||
| - `serviceAccountName`: `string` The name of the ServiceAccount used to | ||
| access the `awsCredsSecret`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to clarify that the Receive Adapter runs as this account. So, the effect is that we access the secret as this Service Account, but it's because the Receive Adapter runs as this Service Account.
Maybe add something like this (not verbatim, but shrug)
// serviceAccountName is the name of the ServiceAccount that will be used to
// run the Receive Adapter Deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to parallel line 184 for the GcpPubSubSource.
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Now that we have https://github.com/knative/docs/tree/master/eventing/sources, we might want to consider replacing this list with a reference to that doc.
That might also require extracting some additional parameter information about the sources, which would be interesting to see if we can automate.
For now, I'm fine with adding this here, but I expect the other page to become the canonical one.
| [ObjectReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#objectreference-v1-core) | ||
| A reference to the object that should receive events. | ||
| - `serviceAccountName`: `string` The name of the ServiceAccount used to | ||
| access the `awsCredsSecret`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to parallel line 184 for the GcpPubSubSource.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, srvaroa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@evankanderson re: automating the parameter information, I've been playing with using the OpenAPI validation that's part of the CRDs with both Google Cloud Scheduler / Google Cloud Storage, and I think it's pretty good start. |
No description provided.