Skip to content

Conversation

@srvaroa
Copy link
Contributor

@srvaroa srvaroa commented Jan 5, 2019

No description provided.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2019
@knative-prow-robot
Copy link
Contributor

Hi @srvaroa. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Galo Navarro <anglorvaroa@gmail.com>
[ObjectReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#objectreference-v1-core)
A reference to the object that should receive events.
- `serviceAccountName`: `string` The name of the ServiceAccount used to
access the `awsCredsSecret`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to clarify that the Receive Adapter runs as this account. So, the effect is that we access the secret as this Service Account, but it's because the Receive Adapter runs as this Service Account.

Maybe add something like this (not verbatim, but shrug)

// serviceAccountName is the name of the ServiceAccount that will be used to
// run the Receive Adapter Deployment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to parallel line 184 for the GcpPubSubSource.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Now that we have https://github.com/knative/docs/tree/master/eventing/sources, we might want to consider replacing this list with a reference to that doc.

That might also require extracting some additional parameter information about the sources, which would be interesting to see if we can automate.

For now, I'm fine with adding this here, but I expect the other page to become the canonical one.

[ObjectReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#objectreference-v1-core)
A reference to the object that should receive events.
- `serviceAccountName`: `string` The name of the ServiceAccount used to
access the `awsCredsSecret`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to parallel line 184 for the GcpPubSubSource.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, srvaroa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 0e9baf6 into knative:master Jan 8, 2019
@vaikas
Copy link
Contributor

vaikas commented Jan 8, 2019

@evankanderson re: automating the parameter information, I've been playing with using the OpenAPI validation that's part of the CRDs with both Google Cloud Scheduler / Google Cloud Storage, and I think it's pretty good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/needs-eng-input Engineering input is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants