Skip to content

Conversation

@RichieEscarez
Copy link
Contributor

@RichieEscarez RichieEscarez commented Jan 8, 2019

Update install landing to include link to the Google codelab

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved labels Jan 8, 2019
@RichieEscarez
Copy link
Contributor Author

Sorry, removed custom install link (forgot that https://github.com/knative/docs/pull/565/files exists).

@samodell
Copy link
Contributor

samodell commented Jan 9, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d7eae8b into master Jan 9, 2019
@RichieEscarez RichieEscarez deleted the RichieEscarez-patch-1 branch January 16, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants