Skip to content

Conversation

@johscheuer
Copy link
Contributor

Correct the serviceAccountName description for the GitHubSource and fix a missing space.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 26, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2019
@knative-prow-robot
Copy link
Contributor

Hi @johscheuer. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 26, 2019
Copy link
Contributor

@samodell samodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Quick wording suggestion.

@johscheuer
Copy link
Contributor Author

Thanks for your suggestion I just oriented at the other descriptions, e.g.: https://github.com/knative/docs/blob/master/eventing/README.md#containersource

@samodell
Copy link
Contributor

@johscheuer

Thanks for your suggestion I just oriented at the other descriptions, e.g.: https://github.com/knative/docs/blob/master/eventing/README.md#containerso

Ah, thanks for pointing out where that came from! Let's actually leave it unchanged for now. Sorry f or the back-and-forth.

@johscheuer
Copy link
Contributor Author

Reverted the changed :)

@samodell
Copy link
Contributor

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johscheuer, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved lgtm Indicates that a PR is ready to be merged. labels Jan 28, 2019
@knative-prow-robot knative-prow-robot merged commit d206063 into knative:master Jan 28, 2019
@johscheuer johscheuer deleted the correct-eventing-docs-github branch January 29, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants