Skip to content

Conversation

mchmarny
Copy link
Member

Eventing release was failing for me due to missing ClusterChannelProvisioner

unable to recognize "https://github.com/knative/eventing/releases/download/v0.4.0/release.yaml": no matches for kind "ClusterChannelProvisioner" in version "eventing.knative.dev/v1alpha1"

Adding https://github.com/knative/eventing/releases/download/v0.4.0/in-memory-channel.yaml fixes this

Fixes #(issue-number)

Proposed Changes


Eventing release was failing for me due to missing `ClusterChannelProvisioner`
```
unable to recognize "https://github.com/knative/eventing/releases/download/v0.4.0/release.yaml": no matches for kind "ClusterChannelProvisioner" in version "eventing.knative.dev/v1alpha1"
```
Adding `https://github.com/knative/eventing/releases/download/v0.4.0/in-memory-channel.yaml` fixes this
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 27, 2019
@knative-prow-robot knative-prow-robot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2019
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be applied to all the "install" documents (e.g. -with-AKS, -custom-install, etc).

Do you want to do that, or should I?

@samodell
Copy link
Contributor

Thanks for pointing that out! I can go ahead and make the change across the rest of the install files, @evankanderson

@evankanderson
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mchmarny, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 52ac2f6 into master Feb 27, 2019
@samodell
Copy link
Contributor

Hey @mchmarny -- I dug into this a bit more; if you installed eventing from release.yaml, then it would have come bundled with the in-memory channel provisioner. @evankanderson confirmed that still holds true in 0.4, so we don't need to add a command for explicitly installing the in-memory channel provisioner. Sounds like you may have installed from eventing.yaml instead, which doesn't come with the in-memory channel provisioner.

@mchmarny
Copy link
Member Author

mchmarny commented Feb 27, 2019 via email

@samodell
Copy link
Contributor

Hmm -- @evankanderson I know you double-checked that release.yaml does include the in-memory channel provisioner, so... any idea what's going on here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants