-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add in-memory-channel to enable eventing release #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Eventing release was failing for me due to missing `ClusterChannelProvisioner` ``` unable to recognize "https://github.com/knative/eventing/releases/download/v0.4.0/release.yaml": no matches for kind "ClusterChannelProvisioner" in version "eventing.knative.dev/v1alpha1" ``` Adding `https://github.com/knative/eventing/releases/download/v0.4.0/in-memory-channel.yaml` fixes this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be applied to all the "install" documents (e.g. -with-AKS, -custom-install, etc).
Do you want to do that, or should I?
Thanks for pointing that out! I can go ahead and make the change across the rest of the install files, @evankanderson |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mchmarny, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @mchmarny -- I dug into this a bit more; if you installed eventing from release.yaml, then it would have come bundled with the in-memory channel provisioner. @evankanderson confirmed that still holds true in 0.4, so we don't need to add a command for explicitly installing the in-memory channel provisioner. Sounds like you may have installed from eventing.yaml instead, which doesn't come with the in-memory channel provisioner. |
Hmm -- @evankanderson I know you double-checked that release.yaml does include the in-memory channel provisioner, so... any idea what's going on here? |
Eventing release was failing for me due to missing
ClusterChannelProvisioner
Adding
https://github.com/knative/eventing/releases/download/v0.4.0/in-memory-channel.yaml
fixes thisFixes #(issue-number)
Proposed Changes