Skip to content

Conversation

samodell
Copy link
Contributor

Undo #944

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 27, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved labels Feb 27, 2019
@RichieEscarez
Copy link
Contributor

sorry been heads down. whats the context for the removal? is there a related issu?

@samodell
Copy link
Contributor Author

samodell commented Feb 27, 2019

@RichieEscarez Context is in a comment on #944 -- you don't need to explicitly install the in-memory channel provisioner if you install eventing using release.yaml, because release.yaml comes with it. And release.yaml was what all the install guides currently have users install. You'd only need to install the in-memory channel provisioner separately if you installed eventing.yaml to begin with.

@samodell
Copy link
Contributor Author

/hold

Mark did install from release.yaml, which should have included the in-memory channel provisioner but apparently did not... Investigation is ongoing in #944

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2019
@samodell
Copy link
Contributor Author

As confirmed in #968 , it isn't necessary to install the in-memory channel provisioner explicitly. Closing this and opening a new PR to delete the extra unnecessary line.

Installs may still fail the first time through with errors like:

unable to recognize "https://github.com/knative/serving/releases/download/v0.4.0/serving.yaml": no matches for kind "Image" in version "caching.internal.knative.dev/v1alpha1"
unable to recognize "https://github.com/knative/build/releases/download/v0.4.0/build.yaml": no matches for kind "Image" in version "caching.internal.knative.dev/v1alpha1"
unable to recognize "https://github.com/knative/build/releases/download/v0.4.0/build.yaml": no matches for kind "Image" in version "caching.internal.knative.dev/v1alpha1"
unable to recognize "https://github.com/knative/build/releases/download/v0.4.0/build.yaml": no matches for kind "Image" in version "caching.internal.knative.dev/v1alpha1"
unable to recognize "https://github.com/knative/build/releases/download/v0.4.0/build.yaml": no matches for kind "Image" in version "caching.internal.knative.dev/v1alpha1"
unable to recognize "https://github.com/knative/eventing/releases/download/v0.4.0/release.yaml": no matches for kind "ClusterChannelProvisioner" in version "eventing.knative.dev/v1alpha1"
unable to recognize "https://github.com/knative/eventing/releases/download/v0.4.0/release.yaml": no matches for kind "ClusterChannelProvisioner" in version "eventing.knative.dev/v1alpha1"

If you see these kinds of errors, run the install commands again to resolve the problem. See #968 for background on what's causing the issue. We also plan to fix this problem in v0.5; to track the fix, see #1036

@samodell samodell closed this Mar 21, 2019
@samodell samodell deleted the samodell-patch-1 branch March 21, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants