Skip to content

Conversation

vlerenc
Copy link

@vlerenc vlerenc commented Mar 6, 2019

Missing manifest, cc @vasu1124.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2019
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vlerenc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Mar 6, 2019
@vlerenc
Copy link
Author

vlerenc commented Mar 6, 2019

/assign @mattmoor

Could you please take a look (the command was suggested automatically).

@samodell
Copy link
Contributor

samodell commented Mar 6, 2019

This is the same issue going on with #944 and #945 -- in theory, you shouldn't need to explicitly install the in-memory channel provisioner if you install eventing from https://github.com/knative/eventing/releases/download/v0.4.0/release.yaml, but in practice people are getting errors without it. We're investigating this.

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2019
@samodell
Copy link
Contributor

Verified this morning that you don't have to explicitly install the in-memory channel provisioner. If install fails on the first attempt, just re-rerun the install commands and it will succeed on second attempt.

@samodell samodell closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Indicates the PR's author has not signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/install size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants