Feat/create path flag #3113

intojhanurag · 2025-10-17T20:34:08Z

This PR fixes the --path flag in the func create command. Previously, cfg.Path was empty when using --path because the path computation happened after the confirm check, causing initialization failure

Before

After

knative-prow · 2025-10-17T20:34:17Z

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-10-17T20:40:31Z

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.07%. Comparing base (71a1f6a) to head (764a87d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/create.go	83.33%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
+ Coverage   58.32%   59.07%   +0.75%     
==========================================
  Files         134      134              
  Lines       17350    17364      +14     
==========================================
+ Hits        10119    10258     +139     
+ Misses       6292     6137     -155     
- Partials      939      969      +30

Flag	Coverage Δ
e2e-tests	`40.25% <83.33%> (+1.37%)`	⬆️
integration-tests	`53.84% <83.33%> (+1.66%)`	⬆️
unit-tests	`46.22% <83.33%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

intojhanurag · 2025-10-18T04:49:33Z

Hey @gauron99 , It is ready for review.

cmd/create.go

gauron99

thanks for the contribution! I added a few questions/suggestions

cmd/create.go

gauron99 · 2025-10-18T06:38:27Z

cmd/create.go

+	// Retain positional [path] for backward compatibility (warned later).
+	cmd.Flags().StringP("path", "p", ".", "Path to the function project directory (default: current directory) ($FUNC_PATH)")
+
+	// Bind the --path flag to viper so it can be read in newCreateConfig


why do we need to bind this to read later? we are not binding other flags and we still read them in createConfig.

I initially tried reading --path without binding it to viper, but viper.GetString("path") returned empty, And with binding it is working🙂

OK I see it. There is a bindEnv function thats being called. You should be able to add path as one of the arguments there and that binds all those flags i mentioned.

gauron99 · 2025-10-18T07:18:36Z

/ok-to-test

docs/reference/func_create.md

intojhanurag · 2025-10-18T08:49:06Z

Hey @gauron99, let me know if any changes are needed. I'm not sure why one of the tests is failing.

gauron99 · 2025-10-18T10:52:10Z

cmd/create.go

+	// Retain positional [path] for backward compatibility (warned later).
+	cmd.Flags().StringP("path", "p", ".", "Path to the function project directory (default: current directory) ($FUNC_PATH)")
+
+	// Bind the --path flag to viper so it can be read in newCreateConfig


OK I see it. There is a bindEnv function thats being called. You should be able to add path as one of the arguments there and that binds all those flags i mentioned.

gauron99 · 2025-10-18T10:52:55Z

cmd/create.go

 	  $ {{.Name}} create -l go -t cloudevents myfunc
 		`,
 		SuggestFor: []string{"vreate", "creaet", "craete", "new"},
 		PreRunE:    bindEnv("language", "template", "repository", "confirm", "verbose"),


we should be able to add path here

Make sense , thanks :)

gauron99 · 2025-10-18T10:54:12Z

Hey @gauron99, let me know if any changes are needed. I'm not sure why one of the tests is failing.

@intojhanurag looks like a flake, I will re-run if it fails again

gauron99 · 2025-10-18T14:20:54Z

Thanks!

/lgtm
/approve

knative-prow · 2025-10-18T14:21:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, intojhanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gauron99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

intojhanurag added 3 commits October 17, 2025 20:16

created path flag

145fcd3

typo-fixes

00b7e41

typo-fix

406542f

knative-prow bot requested review from dsimansk and nainaz October 17, 2025 20:34

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2025

goimports

62c10c5

gauron99 reviewed Oct 18, 2025

View reviewed changes

cmd/create.go Outdated Show resolved Hide resolved

gauron99 reviewed Oct 18, 2025

View reviewed changes

gauron99 self-assigned this Oct 18, 2025

gauron99 removed request for dsimansk and nainaz October 18, 2025 06:40

fixes

5962c3e

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2025

gauron99 reviewed Oct 18, 2025

View reviewed changes

docs/reference/func_create.md Outdated Show resolved Hide resolved

intojhanurag added 2 commits October 18, 2025 08:00

required fixes

ea274eb

docs updated

20acb7e

gauron99 reviewed Oct 18, 2025

View reviewed changes

fix/binding-path

764a87d

knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2025

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2025

knative-prow bot merged commit a4cd23c into knative:main Oct 18, 2025
39 checks passed

lkingland mentioned this pull request Oct 22, 2025

fix: empty name default on create #3127

Open

Feat/create path flag #3113

Feat/create path flag #3113

Uh oh!

Conversation

intojhanurag commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

knative-prow bot commented Oct 17, 2025

Uh oh!

codecov bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

intojhanurag commented Oct 18, 2025

Uh oh!

Uh oh!

gauron99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gauron99 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

intojhanurag Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gauron99 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

gauron99 commented Oct 18, 2025

Uh oh!

Uh oh!

intojhanurag commented Oct 18, 2025

Uh oh!

gauron99 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

gauron99 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

intojhanurag Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

gauron99 commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gauron99 commented Oct 18, 2025

Uh oh!

knative-prow bot commented Oct 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

intojhanurag commented Oct 17, 2025 •

edited

Loading

codecov bot commented Oct 17, 2025 •

edited

Loading

intojhanurag Oct 18, 2025 •

edited

Loading

gauron99 commented Oct 18, 2025 •

edited

Loading