Update github.com/knative/test-infra dependency #11
Conversation
Produced via: `dep ensure -update github.com/knative/test-infra` /assign @mattmoor
knative-prow-robot
added
the
size/XXL
|
Hi @mattmoor-sockpuppet. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
needs-ok-to-test
|
/ok-to-test |
knative-prow-robot
added
lgtm
This form should be more hospitable to running things to auto-update knative/pkg and knative/test-infra I canaried this change in knative/sample-controller, and was able to produce: knative-extensions/sample-controller#11
This form should be more hospitable to running things to auto-update `knative/pkg` and `knative/test-infra`. I canaried this change in `knative/sample-controller`, and was able to produce: knative-extensions/sample-controller#11
This form should be more hospitable to running things to auto-update `knative/pkg` and `knative/test-infra`. I canaried this change in `knative/sample-controller`, and was able to produce: knative-extensions/sample-controller#11
This form should be more hospitable to running things to auto-update `knative/pkg` and `knative/test-infra`. I canaried this change in `knative/sample-controller`, and was able to produce: knative-extensions/sample-controller#11
This form should be more hospitable to running things to auto-update `knative/pkg` and `knative/test-infra`. I canaried this change in `knative/sample-controller`, and was able to produce: knative-extensions/sample-controller#11
* Make a small adjustment to hack/update-deps.sh This form should be more hospitable to running things to auto-update `knative/pkg` and `knative/test-infra`. I canaried this change in `knative/sample-controller`, and was able to produce: knative-extensions/sample-controller#11 * Make the knative/pkg constraint master. This enables the cron to pull knative/pkg forward automatically.
|
dep is currently unnecessarily pulling test-infra/devstats. This should be addressed soon, so if you're OK with that for a while, unhold; otherwise looks like removing the spurious dir is the only option. |
|
Related bug in test-infra: knative/test-infra#850 /lgtm |
knative-prow-robot
added
the
do-not-merge/hold
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mattmoor, mattmoor-sockpuppet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
* Make a small adjustment to hack/update-deps.sh This form should be more hospitable to running things to auto-update knative/pkg and knative/test-infra I canaried this change in knative/sample-controller, and was able to produce: knative-extensions/sample-controller#11 * Make our knative/pkg constraint HEAD. This is so that we can use `dep ensure -update` to fast-forward it.
|
@adrcunha I'm not worried about it. In the grand scheme of things, it's text that compresses well. I'd be more worried if we were vendoring stuff (without pruning) that checked in large binaries. /hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
* Make a small adjustment to hack/update-deps.sh This form should be more hospitable to running things to auto-update `knative/pkg` and `knative/test-infra`. I canaried this change in `knative/sample-controller`, and was able to produce: knative-extensions/sample-controller#11 * Adjust the knative/pkg constraint to track master.
4 participants
Produced via:
dep ensure -update github.com/knative/test-infra/assign @mattmoor