Skip to content

chore: add locale query item and bump version #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

chore: add locale query item and bump version #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Knock.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |spec|
spec.name = "Knock"
spec.version = "1.2.6"
spec.version = "1.2.7"
spec.summary = "An SDK to build in-app notifications experiences in Swift with Knock."

spec.description = <<-DESC
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ If you are managing dependencies using the `Package.swift` file, just add this t

```swift
dependencies: [
.package(url: "https://github.com/knocklabs/knock-swift.git", .upToNextMajor(from: "1.2.6"))
.package(url: "https://github.com/knocklabs/knock-swift.git", .upToNextMajor(from: "1.2.7"))
]
```

Expand All @@ -66,7 +66,7 @@ platform :ios, '16.0'
use_frameworks!

target 'MyApp' do
pod 'Knock', '~> 1.2.6'
pod 'Knock', '~> 1.2.7'
end
```

Expand Down
2 changes: 1 addition & 1 deletion Sources/Knock.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import OSLog

// Knock client SDK.
public class Knock {
internal static let clientVersion = "1.2.6"
internal static let clientVersion = "1.2.7"

public static var shared: Knock = Knock()

Expand Down
3 changes: 2 additions & 1 deletion Sources/Modules/FeedModule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ internal class FeedModule {
URLQueryItem(name: "has_tenant", value: mergedOptions.has_tenant.stringOrNil()),
URLQueryItem(name: "status", value: (mergedOptions.status != nil) ? mergedOptions.status?.rawValue : ""),
URLQueryItem(name: "archived", value: (mergedOptions.archived != nil) ? mergedOptions.archived?.rawValue : ""),
URLQueryItem(name: "trigger_data", value: triggerDataJSON)
URLQueryItem(name: "trigger_data", value: triggerDataJSON),
URLQueryItem(name: "locale", value: mergedOptions.locale)
]

do {
Expand Down